[PrintAsClang] Ensure that all macro-generated decls get printed. #77224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some macro-generated declarations are not being printed in the Obj-C/C++ generated header. Members introduced by attached `member` macros on a type appear to be fine, but those introduced by a attached `peer` or freestanding `declaration` macros don't show up. This change updates the header writer to call `getAllMembers` throughout instead of `getMembers`, which makes sure that everything gets collected. Likewise, we update the top-level logic from `getTopLevelDecls` to `getTopLevelDeclsWithAuxiliaryDecls` to pick up freestanding decls introduced at file scope. Fixes swiftlang#68170.
allevato
requested review from
zoecarver,
hyp,
egorzhdan and
Xazax-hun
as code owners
|
@swift-ci please smoke test |
|
Friendly ping; can someone please take a look at this? @DougGregor @beccadax |
DougGregor
approved these changes
Nov 7, 2024
|
This looks great, @allevato , thank you for the ping and my apologies for missing it. Please feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some macro-generated declarations are not being printed in the Obj-C/C++ generated header. Members introduced by attached
membermacros on a type appear to be fine, but those introduced by a attachedpeeror freestandingdeclarationmacros don't show up.This change updates the header writer to call
getAllMembersthroughout instead ofgetMembers, which makes sure that everything gets collected. Likewise, we update the top-level logic fromgetTopLevelDeclstogetTopLevelDeclsWithAuxiliaryDeclsto pick up freestanding decls introduced at file scope.Fixes #68170.