Sema: Only diagnose explicit unavailable Clang enum elements #77254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftlang#77236 caused a source compatibility regression because `extractEnumElement()` does not suppress its diagnostics in the context of pattern matching. Potentially unavailable enum elements should not be diagnosed when pattern matching since the generated code will not retrieve the potentially unavailable element value on versions where it is unavailable. Fixes rdar://138771328.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test Windows |
tshortli
deleted the
extract-clang-enum-element-versioned-availability
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#77236 caused a source compatibility regression because
extractEnumElement()does not suppress its diagnostics in the context of pattern matching. Potentially unavailable enum elements should not be diagnosed when pattern matching since the generated code will not retrieve the potentially unavailable element value on versions where it is unavailable.Fixes rdar://138771328.