Fix Builtin.FixedArray type reconstruction and change integer type mangling #77273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azoy
requested review from
adrian-prantl,
rjmccall,
mikeash,
al45tair,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to implement type decoder support for
Builtin.FixedArray, so this patch adds that support which fixes type mangling round tripping. Also, the current integer type mangling can sometimes appear before other naturals in the mangling which creates an ambiguity, e.g.$415Synchronizationwhere the integer type is$4and15Synchronizationis the module name. Change the mangling to use the index mangling instead so that it'd be$3_15Synchronization.Resolves: rdar://138798183