Skip to content

Add several argument flags to split-cmdline #77280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

j-hui
Copy link
Contributor

@j-hui j-hui commented Oct 29, 2024

I noticed split-cmdline was missing several flags from its hard-coded list of flags that expect an argument, which I've added in this commit. These are all Swift compiler flags being generated by Xcode and SwiftPM.

@j-hui j-hui requested a review from eeckstein October 29, 2024 20:00
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@eeckstein
Copy link
Contributor

@swift-ci smoke test

@eeckstein eeckstein enabled auto-merge November 4, 2024 09:10
@j-hui j-hui disabled auto-merge November 4, 2024 19:26
@j-hui j-hui force-pushed the update-split-cmdline branch from c9e4b06 to 1d4f4fc Compare November 4, 2024 20:17
@j-hui j-hui force-pushed the update-split-cmdline branch from 1d4f4fc to 8a96fa6 Compare November 4, 2024 20:17
@j-hui j-hui requested a review from eeckstein November 4, 2024 20:17
@j-hui
Copy link
Contributor Author

j-hui commented Nov 4, 2024

@swift-ci Please smoke test

@j-hui
Copy link
Contributor Author

j-hui commented Nov 4, 2024

@eeckstein I added the arguments scraped from --help as we discussed offline, and added a comment documenting how I did that so it can be updated in the future.

It's in a separate commit but I can squash these two when I merge. I've also rebased onto main so that the smoke test will pass.

@j-hui
Copy link
Contributor Author

j-hui commented Nov 5, 2024

@swift-ci Please smoke test

@j-hui j-hui merged commit 1626b0f into swiftlang:main Nov 6, 2024
3 checks passed
@j-hui j-hui deleted the update-split-cmdline branch November 6, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants