Serialization: Recover from errors under loadObjCMethods
#77285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diagnostics about unintended override of Objective-C methods deserializes more decls than strictly necessary. Any of these could trigger a deserialization failure if they rely on missing dependencies. Simply ignore methods failing to deserialize instead of crashing. We could do better here as this logic may ignore methods that are actually colliding. Instead we could put more information in the lookup table to avoid the need for fully deserializing the decl. rdar://138764733
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Windows |
1 similar comment
|
@swift-ci Please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diagnostics about unintended override of Objective-C methods deserialize more decls than strictly necessary. Any of these could trigger a deserialization failure if they rely on hidden dependencies. Simply ignore methods failing to deserialize instead of crashing.
We could improve further if necessary, this logic may ignore methods that are actually colliding. Instead we could put more information in the lookup table to avoid the need to fully deserializing the decls.
rdar://138764733