[SIL] BuiltinInsts have type dependent operands. #77291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has a module or maybe a function. In the future we may want to change this to be either a SILFunction or a SILGlobalVariable.
Take a SILInstructionContext instead of a SILFunction because the latter isn't always available.
Collect all types in the substitution map which constitute type-dependent operands and record them in the instruction's operand list. Fixes a bug where open_existential_metatype (e.g.) is deleted as dead because it has no users even when the type it defines is used in a substitution map of a builtin.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please apple silicon benchmark |
nate-chandler
requested review from
atrick,
eeckstein and
meg-gupta
and removed request for
jckarter
Azoy
reviewed
Oct 30, 2024
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect all types in the substitution map which constitute type-dependent operands and record them in the instruction's operand list. Fixes a bug where
open_existential_metatype(e.g.) is deleted as dead because it has no users even when the type it defines is used in a substitution map of a builtin.