Embedded: Distinguish @_unavailableInEmbedded from @availble(*, unavailable)
#77307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces the layout requirements for `AvailableAttr` by one byte.
This bit is true for attributes written as `@_unavailableInEmbedded` in source.
tshortli
requested review from
xymus,
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight and
rintaro
as code owners
tshortli
force-pushed
the
round-trip-unavailable-in-embedded
branch
from
61f9dec to
daf87c0
Compare
|
@swift-ci please smoke test |
kubamracek
approved these changes
Oct 31, 2024
|
LGTM and thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to solve an ambiguity issue (#77258) we need to distinguish
@_unavailableInEmbeddedattributes from@availble(*, unavailable). Eventually, this will be done by creating a dedicated availability condition for Embedded, but for now we can just store an extra bit onAvailableAttr.