[cxx-interop] Import some C++ methods as Unsafe #77342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClangImporter already had some logic in place to rename certain unsafe C++ methods to make sure their name indicates unsafety. With the recent push for auditability, we have a new @unsafe attribute so we can automate parts of the auditing process. This patch makes sure whenever we rename a method as "Unsafe", we also add the @unsafe attribute.
Xazax-hun
requested review from
zoecarver,
hyp,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClangImporter already had some logic in place to rename certain unsafe C++ methods to make sure their name indicates unsafety. With the recent push for auditability, we have a new @unsafe attribute so we can automate parts of the auditing process. This patch makes sure whenever we rename a method as "Unsafe", we also add the @unsafe attribute.