[ASTGen] Support macro expanded source files #77352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
astgen-macroexpansion
branch
8 times, most recently
from
b099764 to
aca382e
Compare
|
swiftlang/swift-syntax#2889 |
rintaro
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
artemcm,
hborla,
slavapestov and
xedin
as code owners
rintaro
force-pushed
the
astgen-macroexpansion
branch
from
aca382e to
569ff61
Compare
|
swiftlang/swift-syntax#2889 |
DougGregor
approved these changes
Nov 4, 2024
rintaro
force-pushed
the
astgen-macroexpansion
branch
from
569ff61 to
f14bb31
Compare
|
@swift-ci Please smoke test |
hamishknight
approved these changes
Nov 4, 2024
|
|
||
| visitIfConfigElements( | ||
| node.statements, | ||
| of: CodeBlockItemSyntax.self, | ||
| split: Self.splitCodeBlockItemIfConfig | ||
| ) { element in | ||
| let loc = self.generateSourceLoc(element) | ||
| let astNode = generate(codeBlockItem: element) | ||
| if (!isTopLevel) { |
There was a problem hiding this comment.
Suggested change
| if (!isTopLevel) { | |
| if !isTopLevel { |
* Make ExportedSourceFile hold any Syntax as the root node * Move `ExportedSourceFileRequest::evaluate()` to `ParseRequests.cpp` * Pass the decl context and `GeneatedSourceFileInfo::Kind` to `swift_ASTGen_parseSourceFile()` to customize the parsing * Make `ExportedSourceFile` to hold an arbitrary Syntax node * Move round-trip checking into `ExportedSourceFileRequest::evaluate()` * Split `parseSourceFileViaASTGen` completely from C++ parsing logic (in `ParseSourceFileRequest::evaluate()`) * Remove 'ParserDiagnostics' experimental feature: Now that we have ParserASTGen mode which includes the swift-syntax parser diagnostics.
rintaro
force-pushed
the
astgen-macroexpansion
branch
from
f14bb31 to
e566a74
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExportedSourceFileRequest::evaluate()toParseRequests.cppGeneatedSourceFileInfo::Kindtoswift_ASTGen_parseSourceFile()to customize the parsingExportedSourceFileto hold an arbitrary Syntax nodeExportedSourceFileRequest::evaluate()parseSourceFileViaASTGencompletely from C++ parsing logic (inParseSourceFileRequest::evaluate())