Skip to content

Fix typos in VCRuntime modulemap. #77360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

furby-tm
Copy link
Contributor

@furby-tm furby-tm commented Nov 2, 2024

Resolves #77351

We found this issue as apart of our Swift/C++ interop on Windows observations on our Swift forums thread, here.

@furby-tm furby-tm requested a review from a team as a code owner November 2, 2024 01:18
@egorzhdan egorzhdan requested review from compnerd and hyp November 5, 2024 13:25
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@egorzhdan
Copy link
Contributor

@swift-ci please smoke test

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Nov 5, 2024
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@compnerd compnerd merged commit c4266f6 into swiftlang:main Nov 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VCRuntime modulemap contains "cpluplus" typos
3 participants