[Parse] Remove unnecessary dependencies to Parser.h #77361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++ swift::Parser is going to be replaced with SwiftParser+ASTGen. Direct dependencies to it should be removed. Before that, remove unnecessary '#include "swift/Parse/Parser.h"' to clarify what actually depends on 'swift::Parser'. Split 'swift::parseDeclName()' et al. into the dedicated files.
rintaro
requested review from
tshortli,
hborla,
slavapestov,
xedin,
jckarter,
zoecarver,
hyp,
egorzhdan,
Xazax-hun,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
nkcsgexi,
artemcm,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci Please smoke test |
ahoppen
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++
swift::Parseris going to be replaced withSwiftParser+ASTGen. Direct dependencies toswift::Parsershould be removed. Before that, remove unnecessary#include "swift/Parse/Parser.h"to clarify what actually depends on it.Split
swift::parseDeclName()et al. into the dedicated files.rdar://139117268
FYI, the remaining things are:
ClangImporterfor parsingswift_attrattributes