Sema: Introduce getUnmetAvailabilityRequirement()
#77362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's now unused outside of `TypeCheckAvailability.cpp`.
Type checker functions with the prefix "check" usually check some requirement and then diagnose it if it isn't satisfied. `checkDeclarationAvailability()` doesn't diagnose on its own, so it should be named differently.
This type will need to be used outside of Sema.
Introduce a convenience overload for the common case where the AvailabilityContext must first be looked up by source location.
Adopt `getUnmetDeclAvailabilityRequirement()` instead.
tshortli
changed the title
checkDeclarationAvailability() with getUnmetAvailabilityRequirement()getUnmetAvailabilityRequirement()
tshortli
changed the title
getUnmetAvailabilityRequirement()getUnmetAvailabilityRequirement()
tshortli
force-pushed
the
replace-check-declaration-availability
branch
from
7f7664a to
242b9cc
Compare
Adopt `getUnmetDeclAvailabilityRequirement()` instead.
tshortli
force-pushed
the
replace-check-declaration-availability
branch
from
242b9cc to
c044321
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the family of
checkDeclarationAvailability()functions withgetUnmetAvailabilityRequirement(). This will ensure that callers correctly handle all of the possible reasons for unavailability, instead of checking for them piecemeal.NFC.