Skip to content

Updated PlaygroundTransform tests to cover both Swift 5 and 6. #77378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chrismiles
Copy link
Contributor

PlaygroundTransform tests now compile test cases for both Swift language modes 5 and 6.

rdar://139244753

@chrismiles chrismiles self-assigned this Nov 5, 2024
@chrismiles chrismiles added the playground transform Area → compiler → type checker: The Xcode playground transform label Nov 5, 2024
@chrismiles
Copy link
Contributor Author

@swift-ci Please smoke test

@chrismiles

This comment was marked as resolved.

Copy link
Contributor

@abertelrud abertelrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it's of course unfortunate to have to spell out 5 and 6 in all the tests. I know we don't have other options right now. At least everything is normalized now. Thank you!

@abertelrud abertelrud self-requested a review November 6, 2024 17:31
PlaygroundTransform tests now compile test cases for both Swift language modes 5 and 6.
@chrismiles chrismiles force-pushed the eng/chrismiles/playground-transform-test-both-swift-5-and-6 branch from 9d9048a to d287715 Compare November 7, 2024 19:28
@chrismiles
Copy link
Contributor Author

@swift-ci Please smoke test

@chrismiles chrismiles requested a review from xedin November 8, 2024 22:39
@chrismiles chrismiles marked this pull request as ready for review November 11, 2024 19:01
@chrismiles chrismiles merged commit 72b88ce into main Nov 13, 2024
3 checks passed
@chrismiles chrismiles deleted the eng/chrismiles/playground-transform-test-both-swift-5-and-6 branch November 13, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playground transform Area → compiler → type checker: The Xcode playground transform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants