[test] Fail on test requiring features that are not used or had disappeared #77380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not automatically linted because of its extension.
drodriguez
requested review from
hborla,
slavapestov,
xedin,
QuietMisdreavus,
eeckstein,
jckarter and
ktoso
as code owners
|
@swift-ci please test |
When a feature is removed from `Features.def` or when a test removes all usages of `-enable-experimental/upcoming-feature` keeping the `REQUIRES:` lines around is probably a mistake. Warn about possibly missing flags if a `REQUIRES:` is found referencing a feature without the equivalent `-enable-*-feature` in a `RUN:` line.
While doing swiftlang#76740 I iteratively was adding new `REQUIRES:` as new usages of the features were found, but I did not realize that at the same time other people might be removing some of those usages. The tests in this commit had some `REQUIRES:` line for a previous `-enable-experimental/upcoming-feature`, but they not longer use those features, so the `REQUIRES:` were effectively disabling the tests (at least in the case of `KeyPathWithStaticMembers`. In other cases they might still had executed).
drodriguez
force-pushed
the
test-swift-features-cont
branch
from
0d1c04a to
5abb1ea
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing #76740 I iteratively was adding new
REQUIRES:as new usages of the features were found, but I did not realize that at the same time other people might be removing some of those usages. The tests in this commit had someREQUIRES:line for a previous-enable-experimental/upcoming-feature, but they not longer use those features, so theREQUIRES:were effectively disabling the tests (at least in the case ofKeyPathWithStaticMembers. In other cases they might still had executed).