[CapturePromotion] dealloc_box doesn't mutate. #77401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instruction only deallocates the box, it doesn't destroy its contents. It's even less mutating than a `destroy_value`, which is already regarded as non-mutating.
Keep to a single spelling for an "always OK" instruction.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please apple silicon benchmark |
meg-gupta
reviewed
Nov 5, 2024
| @@ -1071,15 +1071,10 @@ class NonEscapingUserVisitor | |||
| ALWAYS_NON_ESCAPING_INST(StrongRelease) | |||
| ALWAYS_NON_ESCAPING_INST(DestroyValue) | |||
| ALWAYS_NON_ESCAPING_INST(EndBorrow) | |||
| ALWAYS_NON_ESCAPING_INST(DeallocBox) | |||
| ALWAYS_NON_ESCAPING_INST(EndAccess) | |||
There was a problem hiding this comment.
Not related to this PR - I noticed copy_value / begin_borrow is not handled here. Maybe it is okay since findEscapeOrMutationUses is looking for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instruction only deallocates the box, it doesn't destroy its contents. It's even less mutating than a
destroy_value, which is already regarded as non-mutating.rdar://139235335