[ASTGen] Simplify diagnostics framework #77404
Merged
+98
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham,
CodaFi and
hamishknight
as code owners
hamishknight
approved these changes
Nov 5, 2024
This simplifies both the diagnostic declarations and usages.
To create a new diangnostic message, create a static method:
extension ASTGenDiagnostic {
static func invalidToken(_ token: TokenSyntax) -> Self {
return Self(
node: token,
message: "invalid token: '\(token.trimmed)'"
)
}
}
To use it In ASTGenVisitor:
self.diagnose(.invalidToken(token))
rintaro
force-pushed
the
astgen-diagnostics-simple
branch
from
983872b to
92c4989
Compare
|
@swift-ci Please smoke test |
DougGregor
approved these changes
Nov 5, 2024
ahoppen
approved these changes
Nov 6, 2024
Comment on lines
+91
to
+92
| missing child token of kind '\(kindOfTokenMissing)' in: | ||
| \(parent.debugDescription(indentString: " ")) |
There was a problem hiding this comment.
Are these messages intended to be multi-line. I don’t think we have multi-line diagnostics anywhere else at the moment.
There was a problem hiding this comment.
I think we need to revisit here before enabling ASTGen by default.
|
@swift-ci Please smoke test Windows |
1 similar comment
|
@swift-ci Please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies both the diagnostic declarations and usages.
To create a new diangnostic message, create a static method in
ASTGen/Diagnostics.swift:To use it in ASTGenVisitor: