[CoroutineAccessors] Synthesize default requirement implementations. #77429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
general-coro/20241104/1
branch
from
de7af46 to
0254b74
Compare
The variable `storage` was defined as `nullptr` a couple lines above and then is check for null, a spurious check. Eliminate that nullcheck--it's always true.
Move the bailout from getSynthesizedAccessor from the wrapper function into the evaluate body. Will enable the request to do work on non-synthesized accessors, which is required to provide a default implementation for modify2 and read2 members.
nate-chandler
force-pushed
the
general-coro/20241104/1
branch
2 times, most recently
from
8f4cf1b to
03e1601
Compare
When a protocol which has a read (or modify) requirement is built with the CoroutineAccessors feature, it gains a read2 (or modify2, respectively) requirement. For this to be compatible with binaries built without the feature, a default implementation for these new requirements must be provided. Cause these new accessor requirements to have default implementations by returning `true` from `doesAccessorHaveBody` when the context is a `ProtocolDecl` and the relevant availability check passes.
nate-chandler
force-pushed
the
general-coro/20241104/1
branch
from
03e1601 to
da71271
Compare
Don't iterate users while deleting them.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please apple silicon benchmark |
nate-chandler
requested review from
jckarter,
AnthonyLatsis,
hborla,
slavapestov,
xedin and
eeckstein
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a protocol which has a
read(ormodify) requirement is built with theCoroutineAccessorsfeature, it gains aread2(ormodify2, respectively) requirement. For this to be compatible with binaries built without the feature, a default implementation for these new requirements must be provided. Cause these new accessor requirements to have default implementations by returningtruefromdoesAccessorHaveBodywhen the context is aProtocolDecland the relevant availability check passes.