[IRGen+Runtime] Fix tag bit mask handling for objc, unknown objects a… #77431
+169
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
mikeash
approved these changes
Nov 6, 2024
mikeash
approved these changes
Nov 7, 2024
| addrOffset = _addrOffset + sizeof(void*); | ||
| object &= ~_swift_abi_SwiftSpareBitsMask; | ||
| _Block_copy((void *)object); |
There was a problem hiding this comment.
Do we know for sure that the block has been copied to the heap already? _Block_copy returns its parameter iff the block isn't still on the stack. I recall that the Swift compiler doesn't try too hard to avoid copying blocks so we may never see a stack block here, but this worries me a bit, especially if the compiler got smarter about not copying nonescaping blocks at some point.
|
@swift-ci smoke test |
…nd blocks rdar://138487964 On platforms that don't have reserved bits in objc (including unknown) pointers, we use the spare bits for Swift enums, so they have to be masked out. Blocks don't have reserved bits on any platform.
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd blocks
rdar://138487964
On platforms that don't have reserved bits in objc (including unknown) pointers, we use the spare bits for Swift enums, so they have to be masked out. Blocks don't have reserved bits on any platform.