[ConstExpr] Relax expectations in ArrayAppendElement to allow direct-passed element #77471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using arrays in a constant-folding string interpolation, under Embedded Swift, we can hit an assert:
This PR fixes that by relaxing the expectation inside the handling of WellKnownFunction::ArrayAppendElement, which have only been expecting that Array.append is generic (non-specialized) and takes the element parameter indirectly. That's not always true under Embedded Swift where Array.append is going to be specialized.
rdar://139351327