Skip to content

Concurrency: Look through l-value types in ActorIsolation::getActor() #77474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Nov 8, 2024

When computing the actor type for an expression, be sure to look through l-value types to get the underlying type.

Resolves rdar://139470254.

When computing the actor type for an expression, be sure to look through
l-value types to get the underlying type.

Resolves rdar://139470254.
@tshortli
Copy link
Contributor Author

tshortli commented Nov 8, 2024

@swift-ci please smoke test

@tshortli tshortli enabled auto-merge November 8, 2024 02:43
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be possible to ask Sema to provide r-value type for this context but this is okay temporarily.

@tshortli tshortli merged commit 2ee2f1e into swiftlang:main Nov 8, 2024
3 checks passed
@tshortli tshortli deleted the lvalue-expr-actor-isolation branch November 8, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants