🍒[6.0][cxx-interop] Fix crash trying to export read accesors #77480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explanation: The reverse interop code assumed that there is always a synthesized get accessor for public stored properties which is not the case. This PR prevents the crash by not exporting get accessor it is not available. Scope: C++ reverse interop. Risk: Low, we just skip problematic operators. Testing: Regression test added. Issue: rdar://138944832 Reviewer: @egorzhdan Original PR: #77391
egorzhdan
approved these changes
Nov 8, 2024
|
@swift-ci please test |
|
@swift-ci please test macos |
|
Closing as this fix is too late for 6.0.x, will be available in 6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The reverse interop code assumed that there is always a synthesized get accessor for public stored properties which is not the case. This PR prevents the crash by not exporting get accessor it is not available.
Scope: C++ reverse interop.
Risk: Low, we just skip problematic operators.
Testing: Regression test added.
Issue: rdar://138944832
Reviewer: @egorzhdan
Original PR: #77391