[xcodegen] Add buildable folder support #77515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires ensuring we check that we're not ever attempting to add a group under an existing folder reference. This will be required for buildable folders.
This only existed to avoid adding anything under a folder reference. Now that we add those references first, this is no longer needed.
This enables the use of folder references for compatible targets, allowing new source files to be added without needing to regenerate the project. Currently disabled by default; I'd like to get some living-on before enabling.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate buildable folders for compatible targets when
--buildable-foldersis passed. Currently disabled by default, I'd like to live on it for a bit before enabling by default, and ideally we'd also split up "umbrella" targets likestdlib+unittestssuch that they can benefit from it.#77418