Teach the TypeRefinementContext not to skip declarations within macro expansions #77517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… expansions The construction of type refinement contexts performs lazy expansion for the contents of macro expansions, so that TRC creation doesn't force all macros to be expanded. However, the logic that skips macro expansions would *also* skip some declarations produced within a macro expansion, even when building the TRC specifically for that macro expansion buffer. This manifest as missing some availability information within the TRC, rejecting some well-formed code. Tune the logic for "don't visit macro expansions when building a TRC" to recognize when we're building a TRC for that macro expansion. Fixes rdar://128400301.
DougGregor
requested review from
tshortli,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
tshortli
reviewed
Nov 11, 2024
| @@ -538,6 +538,69 @@ class TypeRefinementContextBuilder : private ASTWalker { | |||
| return MacroWalking::Arguments; | |||
| } | |||
|
|
|||
| /// Check whether this declaration is in a source file buried within | |||
| /// a macro expansion of the | |||
There was a problem hiding this comment.
Looks like your thought wasn't finished here
There was a problem hiding this comment.
Thank you, finished the thought in #77528
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The construction of type refinement contexts performs lazy expansion for the contents of macro expansions, so that TRC creation doesn't force all macros to be expanded. However, the logic that skips macro expansions would also skip some declarations produced within a macro expansion, even when building the TRC specifically for that macro expansion buffer. This manifest as missing some availability information within the TRC, rejecting some well-formed code.
Tune the logic for "don't visit macro expansions when building a TRC" to recognize when we're building a TRC for that macro expansion.
Fixes rdar://128400301.