Skip to content

[5.10] Add support for swiftlang and apple org repo in update checkout #77536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

hjyamauchi
Copy link
Contributor

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

@compnerd compnerd requested a review from shahmishal November 11, 2024 19:46
@hjyamauchi hjyamauchi marked this pull request as ready for review November 11, 2024 19:47
@shahmishal
Copy link
Member

This was fixed: #77489

@hjyamauchi
Copy link
Contributor Author

hjyamauchi commented Nov 11, 2024

Hi @shahmishal

The cross repo testing didn't work for me on release/5.10 after #77489.

We think this additional cherrypick of #74955 is necessary. Without that, the regex looks for apple/xxx (like apple/llvm-project) while the lookup won't later match the updated repo id swiftlang/llvm-project.

CC @compnerd

@shahmishal shahmishal merged commit 1aa1838 into swiftlang:release/5.10 Nov 11, 2024
3 of 4 checks passed
@shahmishal
Copy link
Member

Thanks @hjyamauchi!

@hjyamauchi
Copy link
Contributor Author

I was able to confirm that this works now! TY @shahmishal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants