Sema: fix reporting reexporting submodules imports as unused in API #77538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
tshortli
approved these changes
Nov 11, 2024
Importing a clang submodule from Swift implies importing the top-level module too. We make sure we don't warn on the import of the top-level module as being unused when the submodule is used by associating all references to the top-level module instead of submodules. This change applies the same logic for transitive imports, marking the import of the top-level module as used instead of the submodule with the `export *`. In the updated test, this silences the following warning: ``` public import of 'ClangReexportedSubmodulePublic' was not used in public declarations or inlinable code ``` rdar://139492772
xymus
force-pushed
the
dont-warn-submodules-reexport
branch
from
b20107e to
a4fcdef
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing a clang submodule from Swift implies importing the top-level module too. We make sure we don't warn on the import of the top-level module as being unused when the submodule is used by associating all references to the top-level module instead of submodules. This change applies the same logic for transitive imports, marking the import of the top-level module as used instead of the submodule with the
export *.In the updated test, this silences the following warning:
rdar://139492772