Skip to content

[cmake] Set SWIFT_STDLIB_HAS_COMMANDLINE #77544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

etcwilde
Copy link
Member

Set the SWIFT_STDLIB_HAS_COMMANDLINE macro when the stdlib has command line support. This is needed while building SwiftCore to ensure that it exports the appropriate symbols.

Set the SWIFT_STDLIB_HAS_COMMANDLINE macro when the stdlib has command
line support. This is needed while building SwiftCore to ensure that it
exports the appropriate symbols.
@etcwilde
Copy link
Member Author

@swift-ci please smoke test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can handle this slightly differently. SwiftPrivateLibcExtras also needs this flag. The shared options are going to be interesting as we need the rest of the modules integrated before we can start hoisting these to avoid having them diverge in different places.

@etcwilde
Copy link
Member Author

The macro is public, so linking against it should propagate it. Once we're to the install story and have CMake export the targets for the supplemental libraries to consume, I believe we can mark the link public on swiftCore, and then linking against swiftCore will pick up the define appropriately too. Either way, we should be able to include it in the config file that the overlay and supplemental libraries consume.

@etcwilde etcwilde merged commit dc66e8d into swiftlang:main Nov 12, 2024
3 checks passed
@etcwilde etcwilde deleted the ewilde/stdlib-rebuild-pass-CommandLine-Support-macro branch November 12, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants