Optimizer: when propagating the concrete type of an existential, make sure to not violate dominance order #77560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci benchmark |
meg-gupta
reviewed
Nov 12, 2024
|
|
||
| singleUser = user; | ||
| if (isa<DeallocStackInst>(user)) |
There was a problem hiding this comment.
Unrelated to PR: we can ignore debug_value as well here.
… sure to not violate dominance order Make sure that an enum is only initialized once before it is taken. This implies that the initialization must dominate the take. Fixes a verifier crash: rdar://139381701
eeckstein
force-pushed
the
fix-silcombine
branch
from
12170f7 to
63141b6
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that an enum is only initialized once before it is taken. This implies that the initialization must dominate the take.
Fixes a verifier crash: rdar://139381701