[CMake] Cleaning up macOS symbol list #77566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Swift stdlib shouldn't be exposing C/C++ symbols by default. There are select functions that should be exposed, like the `_swift_allocObject` and the retain/release functions, but this should be an explicit decision in the sources.
Making a more in-depth pass over the definition macros and flags in SwiftSource.cmake _add_target_variant_swift_compile_flags. These are only flags that actually matter for swiftCore though. This does not include concurrency flags.
Hooks up the definition for back-deployment support and the missing library name needed to get the magic symbols set up right.
|
@swift-ci please smoke test |
compnerd
approved these changes
Nov 12, 2024
justice-adams-apple
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set applies the appropriate fixes to ensure that the symbols exported from
swiftCore.dylibmatch what is expected from the Apple builds, providing knobs to enable and disable the various features. I went through the list of relevant knobs thatadd_swift_target_libraryexposed and made them knobs for the swiftCore build instead, making it easier to enable and disable them depending on the goals of the vendor. I've also hidden the C/C++ symbols by default to ensure that we don't accidentally leak anything.