Skip to content

Preserve extend_lifetime during dead instruction code elimination. #77575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Nov 13, 2024

And remove all trivial extend_lifetime instructions during the MoveOnlyWrappedTypeEliminator pass.

during the MoveOnlyWrappedTypeEliminator pass.

Such instructions are only valid in RAW SIL. This pass generally removes marker
instructions that are only used for ownership diagnostics.

Fixes rdar://139450982 ([GH:swiftlang#77451] Assert failure on
`extend_lifetime` verify with `onone-simplification` pass disabled)
@atrick atrick force-pushed the preserve_extend_lifetime branch from a55a3ea to b30fd77 Compare November 13, 2024 07:56
@atrick atrick marked this pull request as ready for review November 13, 2024 07:57
@atrick
Copy link
Contributor Author

atrick commented Nov 13, 2024

@swift-ci test

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atrick atrick merged commit eb8d9f4 into swiftlang:main Nov 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants