Demangler: Use a bump-pointer allocator for node allocation. #7758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test and merge |
eeckstein
force-pushed
the
bumpptr-allocation
branch
from
b7de174 to
0592486
Compare
|
@swift-ci Please smoke test and merge |
1 similar comment
|
@swift-ci Please smoke test and merge |
This makes the demangler about 10 times faster. It also changes the lifetimes of nodes. Previously nodes were reference-counted. Now the returned demangle node-tree is owned by the Demangler class and it’s lifetime ends with the lifetime of the Demangler. Therefore the old (and already deprecated) global functions demangleSymbolAsNode and demangleTypeAsNode are no longer available. Another change is that the demangling for reflection now only supports the new mangling (which should be no problem because we are generating only new mangled names for reflection).
eeckstein
force-pushed
the
bumpptr-allocation
branch
from
0592486 to
7d7dc5a
Compare
|
@swift-ci Please smoke test and merge |
1 similar comment
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the demangler about 10 times faster.
It also changes the lifetimes of nodes. Previously nodes were reference-counted.
Now the returned demangle node-tree is owned by the Demangler class and it’s lifetime ends with the lifetime of the Demangler.
Therefore the old (and already deprecated) global functions demangleSymbolAsNode and demangleTypeAsNode are no longer available.