[ASTGen] Remove LegacyParser ping-pong mechanism #77619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
commented
Nov 14, 2024
rintaro
force-pushed
the
astgen-no-legacyparser
branch
from
7265f3e to
6e9cec5
Compare
Now that ASTGen should be able to generate most Swift code. Let's remove "legacy parser" call-in, and remove the unhealthy cyclic dependency between lib/Parse and ASTGen.
rintaro
force-pushed
the
astgen-no-legacyparser
branch
from
6e9cec5 to
1fc00ae
Compare
|
@swift-ci Please smoke test |
rintaro
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor and
hamishknight
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
ASTGenshould be able to generate most Swift code. Let's remove "legacy parser" call-in, and remove the unhealthy cyclic dependency between lib/Parse and ASTGen.