Enable NonEscapable types by default and move lifetime dependence support under a new feature #77637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meg-gupta
changed the title
meg-gupta
force-pushed
the
lifetimeexperimental
branch
2 times, most recently
from
e41be3e to
5b73762
Compare
|
@swift-ci test |
meg-gupta
force-pushed
the
lifetimeexperimental
branch
from
5b73762 to
c08c815
Compare
|
@swift-ci test |
meg-gupta
requested review from
hborla,
slavapestov,
xymus,
xedin,
kavon,
eeckstein,
jckarter,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
zoecarver,
hyp,
egorzhdan,
Xazax-hun,
rjmccall,
a team,
AnthonyLatsis,
beccadax,
ian-twilightcoder and
tshortli
as code owners
meg-gupta
force-pushed
the
lifetimeexperimental
branch
2 times, most recently
from
0dddf22 to
ac38a23
Compare
meg-gupta
force-pushed
the
lifetimeexperimental
branch
from
ac38a23 to
083de18
Compare
|
@swift-ci test |
meg-gupta
force-pushed
the
lifetimeexperimental
branch
2 times, most recently
from
134e000 to
d6f9ccc
Compare
|
@swift-ci test |
|
preset=oss-swift-test-stdlib-with-toolchain |
meg-gupta
force-pushed
the
lifetimeexperimental
branch
from
d6f9ccc to
09e1d80
Compare
|
@swift-ci test |
|
preset=oss-swift-test-stdlib-with-toolchain |
meg-gupta
force-pushed
the
lifetimeexperimental
branch
from
09e1d80 to
a5c5c20
Compare
|
@swift-ci test |
meg-gupta
force-pushed
the
lifetimeexperimental
branch
from
a5c5c20 to
2b6c053
Compare
|
@swift-ci test |
atrick
approved these changes
Nov 18, 2024
meg-gupta
force-pushed
the
lifetimeexperimental
branch
from
2b6c053 to
503b8ad
Compare
|
@swift-ci test |
Without this, supported old compilers which don't recognize LifetimeDependence feature but recognize the NonEscapableTypes feature will run into lifetime dependence inference errors on the implicit initializer generated for the stdlib's swiftinterface
meg-gupta
force-pushed
the
lifetimeexperimental
branch
from
503b8ad to
92782a0
Compare
|
@swift-ci test |
Xazax-hun
reviewed
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SE-0446 is accepted - Promote
NonescapableTypesfeature into a LANGUAGE_FEATURE. Move lifetime dependence support under a new experimental flag.LifetimeDependencefeature flag ensures Span's use of lifetime features are appropriately printed and work with older compilers which don't understand them yet.