Use initializer list instead of copy constructor in ExtraInhabitantsValueWitnessTable constructor #7764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alueWitnessTable constructor
|
@swift-ci please smoke test |
|
Crumbs accidental merge... let me know if you have any issues and I can revert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata.h is included by IRGen code, so has to compile with MSVC.
Previously, an MSVC bug/perhaps lack of c++ 14 conformance meant that this code wouldn't compile. According to cppreference "every constructor selected to initializing non-static members and base class must be a constexpr constructor"
https://connect.microsoft.com/VisualStudio/feedback/details/3122313/msvc-cant-compile-constexpr-constructor-initializing-non-static-members-and-base-class
The fix is to use initializer lists to initialize the base class, rather than a copy constructor. This does the same thing.