Skip to content

[embedded] Add back lazy collection operations, collection diffing and StaticBigInt to Embedded Stdlib #77657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

kubamracek
Copy link
Contributor

@kubamracek kubamracek commented Nov 15, 2024

Straightforward enablement of a bunch of files to the Embedded stdlib, which seem to be excluded for no reason:

  • DiscontiguousSlice.swift
  • DropWhile.swift
  • Filter.swift
  • FlatMap.swift
  • Flatten.swift
  • Join.swift
  • Map.swift
  • PrefixWhile.swift
  • CollectionDifference.swift
  • Diffing.swift
  • StaticBigInt.swift
  • UnfoldSequence.swift

rdar://139729059
rdar://139729075
rdar://139729137

@rauhul
Copy link
Member

rauhul commented Nov 15, 2024

thanks!

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@benrimmington
Copy link
Contributor

StaticBigInt will be limited by issue #75652.

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek
Copy link
Contributor Author

StaticBigInt will be limited by issue #75652.

Good point. Let's use #75652 to track that problem. (The suggestion to increase the bitWidth sounds reasonable to me.)

Copy link
Contributor

@phausler phausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me given the current status of embedded

@kubamracek kubamracek merged commit 3fdec21 into swiftlang:main Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants