[Dependency Scanning] Deprecate/Remove batch scanning capability #77719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
requested review from
tshortli,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci test |
2 similar comments
|
@swift-ci test |
cachemeifyoucan
approved these changes
Dec 2, 2024
| @@ -24,8 +24,8 @@ | |||
| /// The version constants for the SwiftDependencyScan C API. | |||
| /// SWIFTSCAN_VERSION_MINOR should increase when there are API additions. | |||
| /// SWIFTSCAN_VERSION_MAJOR is intended for "major" source/ABI breaking changes. | |||
| #define SWIFTSCAN_VERSION_MAJOR 0 | |||
| #define SWIFTSCAN_VERSION_MINOR 10 | |||
| #define SWIFTSCAN_VERSION_MAJOR 1 | |||
|
@swift-ci test macOS platform |
1 similar comment
|
@swift-ci test macOS platform |
artemcm
force-pushed
the
RemoveBatchDependencyScan
branch
from
2551118 to
8505360
Compare
|
@swift-ci test |
artemcm
force-pushed
the
RemoveBatchDependencyScan
branch
from
8505360 to
149f1f7
Compare
|
@swift-ci test |
artemcm
force-pushed
the
RemoveBatchDependencyScan
branch
from
149f1f7 to
9b820da
Compare
|
@swift-ci test |
artemcm
force-pushed
the
RemoveBatchDependencyScan
branch
from
9b820da to
415791f
Compare
Batch dependency scanning was added as a mechanism to support multiple compilation contexts within a single module dependency graph. The Swift compiler and the Explicitly-built modules model has long since abandoned this approach and this code has long been stale. It is time to remove it and its associated C API.
artemcm
force-pushed
the
RemoveBatchDependencyScan
branch
from
415791f to
41e4712
Compare
|
@swift-ci test |
artemcm
requested review from
zoecarver,
hyp,
egorzhdan,
beccadax,
ian-twilightcoder and
Xazax-hun
as code owners
artemcm
force-pushed
the
RemoveBatchDependencyScan
branch
from
c9f0de1 to
8db90f4
Compare
|
@swift-ci test |
artemcm
force-pushed
the
RemoveBatchDependencyScan
branch
from
8db90f4 to
477ba0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch dependency scanning was added as a mechanism to support multiple compilation contexts within a single module dependency graph. The Swift compiler and the Explicitly-built modules model has long since abandoned this approach and this code has long been stale. It is time to remove it and its associated C API.