[SILGen] Disable swift_willThrow(Typed) call in functions that cannot allocate #77748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… allocate Prior to throwing, Swift emits a call to `swift_willThrow(Typed)`, which allows various diagnostic tools (such as debuggers and testing libraries) to intercept errors at the point where they are initially thrown. Since `swift_willThrow(Typed)` can be hooked by arbitrary code at runtime, there is no way for it to meet performance constraints like @_noLocks or @_noAllocation. Therefore, in a function that has those performance constraints specified, disable emission of the call to `swift_willThrow(Typed)`. Fixes rdar://140230684.
|
@swift-ci please smoke test |
eeckstein
reviewed
Nov 21, 2024
There was a problem hiding this comment.
This is not good enough, because performance constraints also apply to all called functions.
I think we can just ignore swift_willThrow in performance diagnostics and call it user responsibility to not hook any allocating/locking function to this runtime function.
Okay, I've come around to this point of view. I'm closing this PR in favor of #77780 that treats the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to throwing, Swift emits a call to
swift_willThrow(Typed), which allows various diagnostic tools (such as debuggers and testing libraries) to intercept errors at the point where they are initially thrown.Since
swift_willThrow(Typed)can be hooked by arbitrary code at runtime, there is no way for it to meet performance constraints like @_noLocks or @_noAllocation. Therefore, in a function that has those performance constraints specified, disable emission of the call toswift_willThrow(Typed).Fixes rdar://140230684.