build: enable ABI breaking std::atomic changes on MSVC #7776
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The std::atomic implementation in MSVC broke ABI compatibility across a minor update (VS2015U2). Permit the ABI breaking change for the use in the runtime.
|
@swift-ci please test and merge |
|
Did the old behaviour this affect the Windows build, or is it just a defensive check? |
|
Yes, the old alignment behaviour is a problem for the build. |
|
Interesting, how would the problem manifest itself? |
|
It would result in a build failure if you were using the right version of the headers. However, if you built against different versions of the SDK, you would get random crashes. |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The std::atomic implementation in MSVC broke ABI compatibility across a
minor update (VS2015U2). Permit the ABI breaking change for the use in
the runtime.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.