[Cmake] hook up SWIFT_STDLIB_TRACING arg #77785
Conversation
|
@swift-ci please smoke test |
Runtimes/Core/CMakeLists.txt
Outdated
| @@ -115,6 +115,8 @@ add_compile_definitions( | |||
| $<$<BOOL:${SwiftCore_ENABLE_UNICODE_DATA}>:-DSWIFT_STDLIB_ENABLE_UNICODE_DATA> # Stubs | |||
| $<$<BOOL:${SwiftCore_ENABLE_ENVIRONMENT}>:-DSWIFT_STDLIB_HAS_ENVIRON> # Concurrency, runtime, shims, platform overlay | |||
| $<$<BOOL:${SwiftCore_ENABLE_BACKDEPLOYMENT_SUPPORT}>:-DSWIFT_STDLIB_SUPPORT_BACK_DEPLOYMENT> # Concurrency, Compatibility override, magic symbols | |||
| $<$<BOOL:${SwiftCore_ENABLE_STDLIB_TRACING}>:-DSWIFT_STDLIB_TRACING> | |||
| $<$<BOOL:${SwiftCore_ENABLE_STDLIB_TRACING}>:-DSWIFT_STDLIB_CONCURRENCY_TRACING> | |||
There was a problem hiding this comment.
This is really getting crazy. Any plans on splitting this up @etcwilde @justice-adams-apple?
There was a problem hiding this comment.
If it only affects the individual libraries, they should probably be attached to that specific library.
I don't mind as a quick fix, but in that case, can we include a comment specifying which libraries it is affecting?
Thanks.
There was a problem hiding this comment.
@etcwilde moved the compile definitions into the runtime cmake target
justice-adams-apple
force-pushed
the
jadams/hook-up-tracing-flags
branch
from
f164842 to
e0a4282
Compare
|
@swift-ci please smoke test |
Runtimes/Core/runtime/CMakeLists.txt
Outdated
| $<$<BOOL:${SwiftCore_BACKTRACER_PATH}>:-DSWIFT_RUNTIME_FIXED_BACKTRACER_PATH="${SwiftCore_BACKTRACER_PATH}">) | ||
| $<$<BOOL:${SwiftCore_BACKTRACER_PATH}>:-DSWIFT_RUNTIME_FIXED_BACKTRACER_PATH="${SwiftCore_BACKTRACER_PATH}"> | ||
| $<$<BOOL:${SwiftCore_ENABLE_STDLIB_TRACING}>:-DSWIFT_STDLIB_TRACING> | ||
| $<$<BOOL:${SwiftCore_ENABLE_STDLIB_TRACING}>:-DSWIFT_STDLIB_CONCURRENCY_TRACING>) |
There was a problem hiding this comment.
Does SWIFT_STDLIB_CONCURRENCY_TRACING have an impact on the runtime objects? I don't see it referenced in these sources.
There was a problem hiding this comment.
I think you're right, I think it got in here since I wanted to use a single CMAKE switch (SwiftCore_ENABLE_STDLIB_TRACING), I'll remove it
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
Add option for
SwiftCore_ENABLE_STDLIB_TRACING