Simplify devirtualization and fix a bug #7779
Conversation
slavapestov
force-pushed
the
devirt-gardening
branch
from
c37b37c to
f3ea3e6
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
It looks like we didn't generate the correct cast instruction in some cases, but another workaround was masking the problem.
It looks like the devirtualizer used to have problems computing method types in the presence of generic substitutions, covariant returns and other things, so it would bail if a perticular set of pre-conditions was not met on the types of original method call and the devirtualized method call. I don't think any of this is necessary anymore. If this patch introduces any regressions, we need to fix the root cause instead of re-introducing this logic.
slavapestov
force-pushed
the
devirt-gardening
branch
from
f3ea3e6 to
2994415
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please test |
|
Build failed |
|
@slavapestov So, you couldn't resit, but remove all this "can be converted in an ABI compatible way" logic? ;-) Overall, it looks simpler. But I see a high potential for breaking things. IIRC, not all of the affected code paths are currently covered by tests. We need to see if it breaks things in the wild. |
|
"So, let's merge and see of anything is broken." That's the spirit :-) |
Replace if statements with asserts, figure out why assert is firing, delete some code, repeat.