AST: Store AvailableAttr's rename decl in split request evaluator storage
#77818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap `RenamedDeclRequest` instead of evaluating it directly.
In the common case where there is no renamed decl for the attribute, just set a few bits in inline storage for `AvailableAttr`.
This unblocks removing `RenameDecl` from `AvailableAttr`.
Rename decls are typically derived from the rename strings attached to a `@available` attributes. It shouldn't be necessary to serialize the cached rename decls since they can be rederived. The only decls that have rename decls and don't have reanme strings are synthesized by ClangImporter and don't get serialized.
The renamed decl is now stored exclusively in the split request evaluator storage, which is more efficient since most availability attributes do not specify a renamed decl.
tshortli
force-pushed
the
renamed-decl-requestification
branch
from
41864cb to
cd13d7d
Compare
|
@swift-ci please test |
tshortli
requested review from
xymus,
hborla,
slavapestov,
xedin,
zoecarver,
hyp,
egorzhdan,
Xazax-hun,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
beccadax and
ian-twilightcoder
as code owners
tshortli
changed the title
AvailableAttr's rename decl in split request evaluator storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the memory footprint of
AvailableAttrsmaller by optimizing for the common case of norename:decl being associated with the attribute.