[cxx-interop] Simplify finding copy/move ctors in IRGen #77855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
egorzhdan
approved these changes
Nov 29, 2024
rjmccall
reviewed
Dec 2, 2024
| for (auto ctor : cxxRecordDecl->ctors()) { | ||
| if (ctor->isCopyConstructor() && | ||
| ctor->getAccess() == clang::AS_public && | ||
| // rdar://106964356 |
There was a problem hiding this comment.
Please don't add naked radar links to the main source code like this. First and foremost, you should describe the issue that you're working around instead of just adding a link. Second, this is an open-source project, so you should really link to an open source GitHub issue which will be readable by non-Apple employees.
There was a problem hiding this comment.
Got it. This one was here before my change. I'll try to replace it with the summary of what the rdar is about in a followup PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.