[AST] Split out "is compound" bit on FunctionRefKind #77896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FunctionRefKind was originally designed to represent the handling needed for argument labels on function references, in which the unapplied and compound cases are effectively the same. However it has since been adopted in a bunch of other places where the spelling of the function reference is entirely orthogonal to the application level. Split out the application level from the "is compound" bit. Should be NFC. I've left some FIXMEs for non-NFC changes that I'll address in a follow-up.
hamishknight
requested review from
hborla,
xedin,
AnthonyLatsis,
slavapestov,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
rintaro,
zoecarver,
hyp,
egorzhdan,
beccadax,
ian-twilightcoder and
Xazax-hun
as code owners
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
DougGregor
approved these changes
Dec 2, 2024
Comment on lines
+29
to
+40
| /// Describes how a function is referenced within an expression node. | ||
| /// | ||
| /// This dictates things like: | ||
| /// - Whether argument labels are part of the resulting function type or not. | ||
| /// - Whether the result can produce an implicitly unwrapped optional. | ||
| /// - Whether the function type needs adjustment for concurrency. | ||
| /// | ||
| /// How a function is referenced comes down to how it was spelled in | ||
| /// the source code, e.g., was it called in the source code and was it | ||
| /// spelled as a compound name. | ||
| class FunctionRefInfo final { | ||
| public: |
There was a problem hiding this comment.
This is a good abstraction, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FunctionRefKind was originally designed to represent the handling needed for argument labels on function references, in which the unapplied and compound cases are effectively the same. However it has since been adopted in a bunch of other places where the spelling of the function reference is entirely orthogonal to the application level.
Split out the application level from the "is compound" bit, and rename to FunctionRefInfo. Should be NFC. I've left some FIXMEs for non-NFC changes that I'll address in a follow-up.
Resolves #77804
rdar://140415962