[ASTGen] Generate several attributes #77905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
astgen-declattr-pt2
branch
3 times, most recently
from
e0ae8f1 to
25fc71d
Compare
|
@swift-ci Please smoke test |
* NonisolatedAttr * SpecializeAttr * UnavailableFromAsyncAttr * DocumentationAttr * StorageRestrictionsAttr
rintaro
force-pushed
the
astgen-declattr-pt2
branch
from
25fc71d to
6d7b3d6
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
rintaro
requested review from
ahoppen,
bnbarham,
CodaFi,
hamishknight,
DougGregor,
hborla,
slavapestov and
xedin
as code owners
hamishknight
approved these changes
Dec 6, 2024
Comment on lines
+222
to
+229
| case SourceFileKind::SIL: | ||
| return false; | ||
| case SourceFileKind::Library: | ||
| case SourceFileKind::Main: | ||
| case SourceFileKind::Interface: | ||
| case SourceFileKind::MacroExpansion: | ||
| case SourceFileKind::DefaultArgument: | ||
| break; |
There was a problem hiding this comment.
Accidental format change?
There was a problem hiding this comment.
Oops. I will fix this when I revisit here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other fixes:
AttrArgumentStateto simplify attribute arguments handlingfoo()