AST: Refactor semantic unavailability queries #77907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
jckarter,
rjmccall,
AnthonyLatsis,
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci please test |
Adopt it in a few places as a replacement for `Decl::getSemanticUnavailableAttr()`.
Also remove the underlying `SemanticUnavailableAttrRequest`, which used memory very inefficiently in order to cache a detailed answer to what was usually a much simpler question. The only remaining use of `Decl::getSemanticUnavailableAttr()` that actually needed to locate the semantic attribute making a declaration unavailable was in `TypeCheckAttr.cpp`. The implementation of the request could just be used directly in that one location. The other remaining callers only needed to know if the decl was unavailable or not, which there are simpler queries for. # Please enter the commit message for your changes. Lines starting
tshortli
force-pushed
the
semantic-decl-availability
branch
from
9e9dd4a to
64f9d5b
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the efficiency and correctness of queries related to semantic availability of decls. Previously,
Decl::getSemanticUnavailableAttr()was the designated query for semantic unavailability, but it cached much richer information than most callers needed and bloated the storage requirements of the request evaluator. Additionally, its results were not actually accurate forDecl::isUnreachableAtRuntime(), since that query has a stricter notion of unavailability. The new request implementation computes a semantic decl availability classification that is suitable for all callers and also can be stored much more efficiently.