[Caching] Downgrade output loading error to a warning #77934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the output loading failed after cache key lookup, treat that as a warning and resume as if that is a cache miss. This is not a valid configuration for builtin CAS but can happen for a remote CAS service that failed to serve the output. Instead of failing, we should continue to compile to avoid disruptive failures. rdar://140822432
cachemeifyoucan
requested review from
artemcm,
tshortli,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
artemcm
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the output loading failed after cache key lookup, treat that as a warning and resume as if that is a cache miss. This is not a valid configuration for builtin CAS but can happen for a remote CAS service that failed to serve the output. Instead of failing, we should continue to compile to avoid disruptive failures.
rdar://140822432