[Syntax] ThreadSafeCachingTests: Use a thread pool #7797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test Linux |
Instead of spawning a thread across test iterations (whoops, out of threads), use a thread pool of size 2. When turning off atomic caching, this is enough to trigger a race in 5 iterations or fewer for me, so 10000 ought to be enough for most machines. This should fix hitting the thread limit on Linux. rdar://problem/30729901
bitjammer
changed the title
|
OK, let's test a few more times. |
|
@swift-ci Please smoke test Linux |
1 similar comment
|
@swift-ci Please smoke test Linux |
|
@swift-ci Please smoke test OS X |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Syntax] ThreadSafeCachingTests: Use a thread pool