Skip to content

Add additional implicit framework search path for Darwin platforms #77991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Dec 5, 2024

/System/Library/SubFrameworks will be searched for frameworks by the compiler implicitly when an SDK path is specified.

Resolves rdar://137454957

@artemcm
Copy link
Contributor Author

artemcm commented Dec 5, 2024

@swift-ci smoke test

@nkcsgexi
Copy link
Contributor

nkcsgexi commented Dec 5, 2024

Thank you! Could you add a test case for implicit module builds? for some reasons, the same patch doesn't work for my in implicit module builds in my previous attempt.

'/System/Library/SubFrameworks' will be searched for frameworks by the compiler implicitly when an SDK path is specified.

Resolves rdar://137454957
@artemcm artemcm force-pushed the SubFrameworksImplicit branch from 87bdf96 to faf0b21 Compare December 5, 2024 21:57
@artemcm artemcm requested a review from xymus as a code owner December 5, 2024 21:57
@artemcm
Copy link
Contributor Author

artemcm commented Dec 5, 2024

@swift-ci smoke test

@artemcm artemcm enabled auto-merge December 5, 2024 21:57
@nkcsgexi
Copy link
Contributor

nkcsgexi commented Dec 5, 2024

Could you cherry-pick to 6.1 as well?

@artemcm
Copy link
Contributor Author

artemcm commented Dec 6, 2024

@swift-ci smoke test Linux platform

@artemcm
Copy link
Contributor Author

artemcm commented Dec 6, 2024

Could you cherry-pick to 6.1 as well?

#78018

@artemcm
Copy link
Contributor Author

artemcm commented Dec 9, 2024

@swift-ci smoke test Linux platform

@artemcm artemcm merged commit 9e60c4f into swiftlang:main Dec 9, 2024
3 checks passed
@artemcm artemcm deleted the SubFrameworksImplicit branch December 9, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants