[test] Only running the test on watchOS simulator #7801
Conversation
|
@swift-ci Please test and merge |
| @@ -1,5 +1,5 @@ | |||
| // RUN: %swift -typecheck -target i386-apple-watchos2.0 -verify -sdk %sdk %s | |||
| // REQUIRES: OS=watchos | |||
| // REQUIRES: CPU=x86_64, OS=watchos | |||
There was a problem hiding this comment.
Do we really support comma as a REQUIRES joiner?
There was a problem hiding this comment.
@jrose-apple I found it somewhere, not invented it =)
There was a problem hiding this comment.
18:00:42 UNSUPPORTED: Swift(watchsimulator-i386) :: stdlib/DispatchDeprecationWatchOS.swift (431 of 9456)
Looks like it's no good. It might just be that you need to use i386 instead of x86_64, but please test locally before merging!
There was a problem hiding this comment.
We can use \s*,\s* as a separator
https://github.com/apple/swift-llvm/blob/stable/utils/lit/lit/TestRunner.py#L841
There was a problem hiding this comment.
Maybe these things can be documented somewhere.
There was a problem hiding this comment.
Patches to lit are always welcome. :)
There was a problem hiding this comment.
Documentation is http://llvm.org/docs/TestingGuide.html
…but some of the LLVM branches used by Swift do not yet support the boolean operators.
Comma-separated clauses act as if they were specified independently on separate lines. REQUIRES: a, b requires both a and b to be true.
There was a problem hiding this comment.
Thanks @gparker42, I was mostly thinking about the values of the tags that are used in Swift. They are all defined somewhere in lit.cfg but there is just no list with all of the possible tags and their values.
There was a problem hiding this comment.
docs/Testing.rst has a few of them…and a FIXME to add the rest.
|
@swift-ci Please smoke test Linux platform |
<rdar://problem/29996841>
|
@swift-ci Please test |
|
Hit it this time. |
rdar://problem/29996841