Skip to content

[6.1] [IDE] Handle UnresolvedMemberExpr for solver-based cursor info #78012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hamishknight
Copy link
Contributor

6.1 cherry-pick part of c4efa0d

  • Explanation: Allows solver-based cursor info to be used with UnresolvedMemberExprs
  • Scope: Affects solver-based cursor info
  • Issue: rdar://140980197
  • Risk: Low, applies existing logic to more cases
  • Testing: Added tests to test suite
  • Reviewer: Alex Hoppen

Factor out `Expr::getNameLoc`, and make sure we handle
UnresolvedMemberExpr. This enables solver-based cursor
info for it.

rdar://140980197
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.1 labels Dec 6, 2024
@hamishknight hamishknight requested a review from bnbarham December 6, 2024 12:10
@hamishknight hamishknight requested a review from a team as a code owner December 6, 2024 12:10
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight merged commit f1a10a0 into swiftlang:release/6.1 Dec 6, 2024
5 checks passed
@hamishknight hamishknight deleted the ume-cursor-info-6.1 branch December 6, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants