-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[cxx-interop] Support CxxStdlib overlay for libc++ on Linux #78014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
@swift-ci please build toolchain Ubuntu 22.04 |
f53b8bf
to
2e5bb79
Compare
@swift-ci please test |
@swift-ci please build toolchain Ubuntu 22.04 |
@swift-ci please build toolchain Ubuntu 24.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This teaches Swift to rebuild the CxxStdlib overlay module from its interface when using a C++ standard library that is not the platform default, specifically libc++ on Linux. rdar://138838506
2e5bb79
to
282f3b1
Compare
@swift-ci please smoke test |
@swift-ci please build toolchain Ubuntu 24.04 |
@swift-ci please build toolchain Ubuntu 22.04 |
@swift-ci please build toolchain Amazon Linux 2 |
@swift-ci please build toolchain Ubuntu 22.04 |
@beccadax could you please take a look at this? |
@swift-ci please smoke test |
@swift-ci please smoke test Linux |
I'm merging this, but I'm happy to address review feedback post-merge. |
This teaches Swift to rebuild the CxxStdlib overlay module from its interface when using a C++ standard library that is not the platform default, specifically libc++ on Linux.
rdar://138838506