Skip to content

[cxx-interop] Support CxxStdlib overlay for libc++ on Linux #78014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

egorzhdan
Copy link
Contributor

This teaches Swift to rebuild the CxxStdlib overlay module from its interface when using a C++ standard library that is not the platform default, specifically libc++ on Linux.

rdar://138838506

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Dec 6, 2024
@egorzhdan
Copy link
Contributor Author

@swift-ci please test

@egorzhdan
Copy link
Contributor Author

@swift-ci please build toolchain Ubuntu 22.04

@egorzhdan egorzhdan force-pushed the egorzhdan/libcxx-overlay-linux branch from f53b8bf to 2e5bb79 Compare December 9, 2024 15:40
@egorzhdan
Copy link
Contributor Author

@swift-ci please test

@egorzhdan
Copy link
Contributor Author

@swift-ci please build toolchain Ubuntu 22.04

@egorzhdan egorzhdan marked this pull request as ready for review December 9, 2024 15:40
@egorzhdan
Copy link
Contributor Author

@swift-ci please build toolchain Ubuntu 24.04

Copy link
Contributor

@Xazax-hun Xazax-hun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This teaches Swift to rebuild the CxxStdlib overlay module from its interface when using a C++ standard library that is not the platform default, specifically libc++ on Linux.

rdar://138838506
@egorzhdan egorzhdan force-pushed the egorzhdan/libcxx-overlay-linux branch from 2e5bb79 to 282f3b1 Compare December 10, 2024 14:20
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor Author

@swift-ci please build toolchain Ubuntu 24.04

@egorzhdan
Copy link
Contributor Author

@swift-ci please build toolchain Ubuntu 22.04

@egorzhdan
Copy link
Contributor Author

@swift-ci please build toolchain Amazon Linux 2

@egorzhdan egorzhdan requested a review from nkcsgexi December 11, 2024 13:50
@egorzhdan
Copy link
Contributor Author

@swift-ci please build toolchain Ubuntu 22.04

@fahadnayyar fahadnayyar self-requested a review December 13, 2024 17:23
@nkcsgexi
Copy link
Contributor

@beccadax could you please take a look at this?

@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test Linux

@egorzhdan
Copy link
Contributor Author

I'm merging this, but I'm happy to address review feedback post-merge.

@egorzhdan egorzhdan merged commit 752cb36 into main Jan 20, 2025
6 checks passed
@egorzhdan egorzhdan deleted the egorzhdan/libcxx-overlay-linux branch January 20, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants